Messages in this thread | ![/](/images/icornerl.gif) | | From | Geert Uytterhoeven <> | Date | Mon, 13 Mar 2023 12:00:00 +0100 | Subject | Re: [PATCH] pinctrl: Use of_property_present() for testing DT property presence |
| |
On Mon, Mar 13, 2023 at 10:00 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Fri, Mar 10, 2023 at 3:56 PM Rob Herring <robh@kernel.org> wrote: > > It is preferred to use typed property access functions (i.e. > > of_property_read_<type> functions) rather than low-level > > of_get_property/of_find_property functions for reading properties. As > > part of this, convert of_get_property/of_find_property calls to the > > recently added of_property_present() helper when we just want to test > > for presence of a property and nothing more. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > Thanks for your patch! > > > --- a/drivers/pinctrl/renesas/pinctrl.c > > +++ b/drivers/pinctrl/renesas/pinctrl.c > > @@ -125,8 +125,8 @@ static int sh_pfc_dt_subnode_to_map(struct pinctrl_dev *pctldev, > > * inside a subnode nor across subnodes. > > */ > > if (!pmx->func_prop_name) { > > - if (of_find_property(np, "groups", NULL) || > > - of_find_property(np, "pins", NULL)) { > > + if (of_property_present(np, "groups")|| > > + of_property_present(np, "pins")) { > > pmx->func_prop_name = "function"; > > pmx->groups_prop_name = "groups"; > > pmx->pins_prop_name = "pins"; > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > This check is used to auto-detect if the standard property names > should be used, or the "renesas,"-prefixed ones. > As the last users of the latter were removed from DTS in v4.10, > perhaps I should just remove these checks instead?
Sent a patch just doing that, so you can drop this chunk. https://lore.kernel.org/linux-renesas-soc/ff9c14781110bbf19b56b45dd1f01e6da90319ad.1678704441.git.geert+renesas@glider.be
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| ![\](/images/icornerr.gif) |