Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 13 Mar 2023 11:20:05 +0100 | Subject | Re: [PATCH] pinctrl: s32cc: fix !CONFIG_PM_SLEEP build error |
| |
On Fri, Mar 10, 2023 at 3:02 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de> > > The declaration of s32_pinctrl_suspend/s32_pinctrl_resume is hidden > in an #ifdef, causing a compilation failure when CONFIG_PM_SLEEP is > disabled: > > drivers/pinctrl/nxp/pinctrl-s32g2.c:754:38: error: 's32_pinctrl_suspend' undeclared here (not in a function); did you mean 's32_pinctrl_probe'? > drivers/pinctrl/nxp/pinctrl-s32g2.c:754:9: note: in expansion of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' > 754 | SET_LATE_SYSTEM_SLEEP_PM_OPS(s32_pinctrl_suspend, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Remove the bogus #ifdef and __maybe_unused annation on the global > functions, and instead use the proper LATE_SYSTEM_SLEEP_PM_OPS() > macro to pick set the function pointer. > > As the function definition is still in the #ifdef block, this leads > to the correct code in all configurations. > > Fixes: fd84aaa8173d ("pinctrl: add NXP S32 SoC family support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied.
Yours, Linus Walleij
| |