lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net] net: ethernet: fix use after free bug in ns83820_remove_one due to race condition
On Thu,  9 Mar 2023 17:42:31 +0800 Zheng Wang wrote:
> + cancel_work_sync(&dev->tq_refill);
> ns83820_disable_interrupts(dev); /* paranoia */
>
> unregister_netdev(ndev);

Canceling the work before unregister can't work.
Please take a closer look, the work to refill a ring should be
canceled when the ring itself is dismantled.

\
 
 \ /
  Last update: 2023-03-27 00:57    [W:0.110 / U:1.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site