lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 03/16] dt-bindings: net: dwmac: Fix the TSO property declaration
    Date
    Indeed the STMMAC driver doesn't take the vendor-specific compatible
    string into account to parse the "snps,tso" boolean property. It just
    makes sure the node is compatible with DW MAC 4.x, 5.x and DW xGMAC
    IP-cores. The original allwinner sunXi bindings file also didn't have the
    TSO-related property declared. Neither Ingenic nor Loongson LLD drivers
    activate the GMAC4/5/etc-specific core code. Taking all of that into
    account fix the conditional statement so the TSO-property would be
    evaluated for the compatibles having the corresponding IP-core version by
    dropping all of the vendor-specific compatibles from the property
    conditional statement.

    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    Reviewed-by: Rob Herring <robh@kernel.org>

    ---

    Note this won't break the bindings description, since the "snps,tso"
    property isn't parsed by the denoted glue drivers, but only by the generic
    platform DT-parser.

    Changelog v1:
    - Use correct syntax of the JSON pointers, so the later would begin
    with a '/' after the '#'.
    ---
    .../devicetree/bindings/net/snps,dwmac.yaml | 15 ---------------
    1 file changed, 15 deletions(-)

    diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    index fb9b8506a48f..92feed3c29bc 100644
    --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
    @@ -590,27 +590,12 @@ allOf:
    compatible:
    contains:
    enum:
    - - allwinner,sun7i-a20-gmac
    - - allwinner,sun8i-a83t-emac
    - - allwinner,sun8i-h3-emac
    - - allwinner,sun8i-r40-gmac
    - - allwinner,sun8i-v3s-emac
    - - allwinner,sun50i-a64-emac
    - - loongson,ls2k-dwmac
    - - loongson,ls7a-dwmac
    - - ingenic,jz4775-mac
    - - ingenic,x1000-mac
    - - ingenic,x1600-mac
    - - ingenic,x1830-mac
    - - ingenic,x2000-mac
    - snps,dwmac-4.00
    - snps,dwmac-4.10a
    - snps,dwmac-4.20a
    - snps,dwmac-5.10a
    - snps,dwxgmac
    - snps,dwxgmac-2.10
    - - st,spear600-gmac
    -
    then:
    properties:
    snps,tso:
    --
    2.39.2

    \
     
     \ /
      Last update: 2023-03-27 00:57    [W:7.287 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site