lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net 04/13] net: stmmac: dwmac-sun8i: Don't modify chain-mode module parameter
    Date
    Doing so activates the chain-mode for any DW MAC-based NIC on the platform
    no matter with what parameter the module is loaded. Even if there is no
    any other network controller on the SoC it is logically incorrect.

    Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    ---
    drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    index 8f543c3ab5c5..2ed63acaee5b 100644
    --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    @@ -6806,8 +6806,9 @@ static int stmmac_hw_init(struct stmmac_priv *priv)

    /* dwmac-sun8i only work in chain mode */
    if (priv->plat->has_sun8i)
    - chain_mode = 1;
    - priv->chain_mode = chain_mode;
    + priv->chain_mode = 1;
    + else
    + priv->chain_mode = chain_mode;

    /* Initialize HW Interface */
    ret = stmmac_hwif_init(priv);
    --
    2.39.2

    \
     
     \ /
      Last update: 2023-03-27 00:57    [W:5.169 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site