Messages in this thread | | | Date | Mon, 13 Mar 2023 17:19:06 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v1 02/13] perf build: Make BUILD_BPF_SKEL default, rename to NO_BPF_SKEL |
| |
Em Fri, Mar 10, 2023 at 10:57:42PM -0800, Ian Rogers escreveu: > BPF skeleton support is now key to a number of perf features. Rather > than making it so that BPF support must be enabled for the build, make > this the default and error if the build lacks a clang and libbpf that > are sufficient. To avoid the error and build without BPF skeletons the > NO_BPF_SKEL=1 flag can be used. Add a build-options flag to 'perf > version' to enable detection of the BPF skeleton support and use this > in the offcpu shell test.
Checking this:
cd . && make LIBBPF_DYNAMIC=1 FEATURES_DUMP=/var/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.Rr5xDuXo13 DESTDIR=/tmp/tmp.cYdDvy09eY BUILD: Doing 'make -j32' parallel build HOSTCC /tmp/tmp.Rr5xDuXo13/fixdep.o HOSTLD /tmp/tmp.Rr5xDuXo13/fixdep-in.o LINK /tmp/tmp.Rr5xDuXo13/fixdep Warning: Kernel ABI header at 'tools/include/uapi/linux/in.h' differs from latest version at 'include/uapi/linux/in.h' diff -u tools/include/uapi/linux/in.h include/uapi/linux/in.h Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h' diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h Warning: Kernel ABI header at 'tools/arch/arm64/include/uapi/asm/perf_regs.h' differs from latest version at 'arch/arm64/include/uapi/asm/perf_regs.h' diff -u tools/arch/arm64/include/uapi/asm/perf_regs.h arch/arm64/include/uapi/asm/perf_regs.h Warning: Kernel ABI header at 'tools/include/linux/coresight-pmu.h' differs from latest version at 'include/linux/coresight-pmu.h' diff -u tools/include/linux/coresight-pmu.h include/linux/coresight-pmu.h Makefile.config:1130: No openjdk development package found, please install JDK package, e.g. openjdk-8-jdk, java-1.8.0-openjdk-devel
GEN /tmp/tmp.Rr5xDuXo13/common-cmds.h CC /tmp/tmp.Rr5xDuXo13/dlfilters/dlfilter-test-api-v0.o CC /tmp/tmp.Rr5xDuXo13/dlfilters/dlfilter-show-cycles.o LINK /tmp/tmp.Rr5xDuXo13/dlfilters/dlfilter-test-api-v0.so LINK /tmp/tmp.Rr5xDuXo13/dlfilters/dlfilter-show-cycles.so INSTALL /tmp/tmp.Rr5xDuXo13/libsubcmd/include/subcmd/exec-cmd.h INSTALL /tmp/tmp.Rr5xDuXo13/libsubcmd/include/subcmd/help.h INSTALL /tmp/tmp.Rr5xDuXo13/libsubcmd/include/subcmd/pager.h INSTALL /tmp/tmp.Rr5xDuXo13/libsubcmd/include/subcmd/parse-options.h INSTALL /tmp/tmp.Rr5xDuXo13/libsubcmd/include/subcmd/run-command.h CC /tmp/tmp.Rr5xDuXo13/libsubcmd/exec-cmd.o CC /tmp/tmp.Rr5xDuXo13/libsubcmd/help.o CC /tmp/tmp.Rr5xDuXo13/libsubcmd/pager.o CC /tmp/tmp.Rr5xDuXo13/libsubcmd/parse-options.o CC /tmp/tmp.Rr5xDuXo13/libsubcmd/run-command.o CC /tmp/tmp.Rr5xDuXo13/libsubcmd/sigchain.o CC /tmp/tmp.Rr5xDuXo13/libsubcmd/subcmd-config.o MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/ MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/ INSTALL libsubcmd_headers INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/hashmap.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/relo_core.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/libbpf_internal.h PERF_VERSION = 6.3.rc1.g0b82b38b7b56 INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/perf/bpf_perf.h INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/perf/core.h INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/perf/cpumap.h INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/perf/threadmap.h INSTALL /tmp/tmp.Rr5xDuXo13/libsymbol/include/symbol/kallsyms.h INSTALL /tmp/tmp.Rr5xDuXo13/libapi/include/api/cpu.h INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/perf/evlist.h INSTALL /tmp/tmp.Rr5xDuXo13/libapi/include/api/debug.h INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/perf/evsel.h INSTALL /tmp/tmp.Rr5xDuXo13/libapi/include/api/io.h GEN perf-archive INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/perf/event.h INSTALL /tmp/tmp.Rr5xDuXo13/libapi/include/api/fd/array.h GEN perf-iostat INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/perf/mmap.h CC /tmp/tmp.Rr5xDuXo13/libperf/core.o CC /tmp/tmp.Rr5xDuXo13/libsymbol/kallsyms.o CC /tmp/tmp.Rr5xDuXo13/libapi/cpu.o INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/internal/cpumap.h INSTALL /tmp/tmp.Rr5xDuXo13/libapi/include/api/fs/fs.h INSTALL /tmp/tmp.Rr5xDuXo13/libapi/include/api/fs/tracing_path.h MKDIR /tmp/tmp.Rr5xDuXo13/libapi/fd/ CC /tmp/tmp.Rr5xDuXo13/libapi/debug.o CC /tmp/tmp.Rr5xDuXo13/libapi/str_error_r.o CC /tmp/tmp.Rr5xDuXo13/libperf/cpumap.o INSTALL libsymbol_headers INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/internal/evlist.h CC /tmp/tmp.Rr5xDuXo13/libperf/threadmap.o INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/internal/evsel.h CC /tmp/tmp.Rr5xDuXo13/libperf/evsel.o INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/internal/lib.h CC /tmp/tmp.Rr5xDuXo13/libperf/evlist.o INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/internal/mmap.h MKDIR /tmp/tmp.Rr5xDuXo13/libapi/fs/ INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/internal/threadmap.h CC /tmp/tmp.Rr5xDuXo13/libapi/fd/array.o MKDIR /tmp/tmp.Rr5xDuXo13/libapi/fs/ CC /tmp/tmp.Rr5xDuXo13/libperf/mmap.o INSTALL /tmp/tmp.Rr5xDuXo13/libperf/include/internal/xyarray.h CC /tmp/tmp.Rr5xDuXo13/libapi/fs/fs.o CC /tmp/tmp.Rr5xDuXo13/libperf/zalloc.o CC /tmp/tmp.Rr5xDuXo13/libperf/xyarray.o CC /tmp/tmp.Rr5xDuXo13/libapi/fs/cgroup.o CC /tmp/tmp.Rr5xDuXo13/libperf/lib.o INSTALL libapi_headers CC /tmp/tmp.Rr5xDuXo13/libapi/fs/tracing_path.o INSTALL libperf_headers GEN /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/bpf_helper_defs.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/bpf.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/libbpf.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/btf.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/libbpf_common.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/libbpf_legacy.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/bpf_helpers.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/bpf_tracing.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/bpf_endian.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/bpf_core_read.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/skel_internal.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/libbpf_version.h INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/usdt.bpf.h LD /tmp/tmp.Rr5xDuXo13/libapi/fd/libapi-in.o LD /tmp/tmp.Rr5xDuXo13/libsymbol/libsymbol-in.o AR /tmp/tmp.Rr5xDuXo13/libsymbol/libsymbol.a LD /tmp/tmp.Rr5xDuXo13/libapi/fs/libapi-in.o INSTALL /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/include/bpf/bpf_helper_defs.h MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ INSTALL libbpf_headers MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ LD /tmp/tmp.Rr5xDuXo13/libapi/libapi-in.o MKDIR /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/libbpf.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/bpf.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/libbpf_probes.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/hashmap.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/nlattr.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/btf_dump.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/btf.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/libbpf_errno.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/str_error.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/netlink.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/ringbuf.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/bpf_prog_linfo.o LD /tmp/tmp.Rr5xDuXo13/libperf/libperf-in.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/strset.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/linker.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/gen_loader.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/relo_core.o AR /tmp/tmp.Rr5xDuXo13/libapi/libapi.a CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/usdt.o AR /tmp/tmp.Rr5xDuXo13/libperf/libperf.a LD /tmp/tmp.Rr5xDuXo13/libsubcmd/libsubcmd-in.o AR /tmp/tmp.Rr5xDuXo13/libsubcmd/libsubcmd.a GEN /tmp/tmp.Rr5xDuXo13/python/perf.cpython-311-x86_64-linux-gnu.so LD /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/staticobjs/libbpf-in.o LINK /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/libbpf/libbpf.a CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/main.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/common.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/json_writer.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/gen.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/btf.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/xlated_dumper.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/btf_dumper.o CC /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/disasm.o LINK /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bootstrap/bpftool GEN /tmp/tmp.Rr5xDuXo13/util/bpf_skel/vmlinux.h CLANG /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bpf_prog_profiler.bpf.o CLANG /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bperf_leader.bpf.o CLANG /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bperf_follower.bpf.o CLANG /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bperf_cgroup.bpf.o CLANG /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/func_latency.bpf.o CLANG /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/off_cpu.bpf.o CLANG /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/lock_contention.bpf.o CLANG /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/kwork_trace.bpf.o util/bpf_skel/lock_contention.bpf.c:192:7: error: call to undeclared function 'bpf_core_type_matches'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] if (bpf_core_type_matches(struct rw_semaphore___old)) { ^ util/bpf_skel/lock_contention.bpf.c:192:29: error: expected expression if (bpf_core_type_matches(struct rw_semaphore___old)) { ^ util/bpf_skel/lock_contention.bpf.c:195:36: error: expected expression } else if (bpf_core_type_matches(struct rw_semaphore___new)) { ^ 3 errors generated. /usr/bin/ld: bpf architecture of input file `/tmp/bperf_follower-74fba5.o' is incompatible with i386:x86-64 output /usr/bin/ld: bpf architecture of input file `/tmp/bperf_leader-b2ec61.o' is incompatible with i386:x86-64 output /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/12/../../../../lib64/crt1.o: in function `_start': (.text+0x1b): undefined reference to `main' /usr/bin/ld: final link failed: file in wrong format /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/12/../../../../lib64/crt1.o: in function `_start': (.text+0x1b): undefined reference to `main' /usr/bin/ld: final link failed: file in wrong format collect2: error: ld returned 1 exit status collect2: error: ld returned 1 exit status clang-15: error: linker (via gcc) command failed with exit code 1 (use -v to see invocation) clang-15: error: linker (via gcc) command failed with exit code 1 (use -v to see invocation) /usr/bin/ld: bpf architecture of input file `/tmp/func_latency-70b7d4.o' is incompatible with i386:x86-64 output make[4]: *** [Makefile.perf:1081: /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/lock_contention.bpf.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[4]: *** [Makefile.perf:1081: /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bperf_follower.bpf.o] Error 1 make[4]: *** [Makefile.perf:1081: /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bperf_leader.bpf.o] Error 1 /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/12/../../../../lib64/crt1.o: in function `_start': (.text+0x1b): undefined reference to `main' /usr/bin/ld: final link failed: file in wrong format collect2: error: ld returned 1 exit status clang-15: error: linker (via gcc) command failed with exit code 1 (use -v to see invocation) make[4]: *** [Makefile.perf:1081: /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/func_latency.bpf.o] Error 1 /usr/bin/ld: bpf architecture of input file `/tmp/bpf_prog_profiler-6e9720.o' is incompatible with i386:x86-64 output /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/12/../../../../lib64/crt1.o: in function `_start': (.text+0x1b): undefined reference to `main' /usr/bin/ld: final link failed: file in wrong format collect2: error: ld returned 1 exit status clang-15: error: linker (via gcc) command failed with exit code 1 (use -v to see invocation) make[4]: *** [Makefile.perf:1081: /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bpf_prog_profiler.bpf.o] Error 1 /usr/bin/ld: bpf architecture of input file `/tmp/kwork_trace-8d5b4e.o' is incompatible with i386:x86-64 output /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/12/../../../../lib64/crt1.o: in function `_start': (.text+0x1b): undefined reference to `main' /usr/bin/ld: final link failed: file in wrong format collect2: error: ld returned 1 exit status clang-15: error: linker (via gcc) command failed with exit code 1 (use -v to see invocation) make[4]: *** [Makefile.perf:1081: /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/kwork_trace.bpf.o] Error 1 /usr/bin/ld: bpf architecture of input file `/tmp/off_cpu-1cb75d.o' is incompatible with i386:x86-64 output /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/12/../../../../lib64/crt1.o: in function `_start': (.text+0x1b): undefined reference to `main' /usr/bin/ld: final link failed: file in wrong format collect2: error: ld returned 1 exit status clang-15: error: linker (via gcc) command failed with exit code 1 (use -v to see invocation) make[4]: *** [Makefile.perf:1081: /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/off_cpu.bpf.o] Error 1 /usr/bin/ld: bpf architecture of input file `/tmp/bperf_cgroup-45eb44.o' is incompatible with i386:x86-64 output /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/12/../../../../lib64/crt1.o: in function `_start': (.text+0x1b): undefined reference to `main' /usr/bin/ld: final link failed: file in wrong format collect2: error: ld returned 1 exit status clang-15: error: linker (via gcc) command failed with exit code 1 (use -v to see invocation) make[4]: *** [Makefile.perf:1081: /tmp/tmp.Rr5xDuXo13/util/bpf_skel/.tmp/bperf_cgroup.bpf.o] Error 1 make[3]: *** [Makefile.perf:236: sub-make] Error 2 make[2]: *** [Makefile:70: all] Error 2 make[1]: *** [tests/make:326: make_libbpf_dynamic_O] Error 1 make: *** [Makefile:103: build-test] Error 2 make: Leaving directory '/var/home/acme/git/perf-tools-next/tools/perf'
real 5m55.192s user 62m31.596s sys 14m30.828s ⬢[acme@toolbox perf-tools-next]$
| |