Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 12 Mar 2023 20:10:01 +0000 | From | "Russell King (Oracle)" <> | Subject | Re: Re: Re: [PATCH net-next v12 08/18] net: ethernet: mtk_eth_soc: fix 1000Base-X and 2500Base-X modes |
| |
On Sun, Mar 12, 2023 at 05:50:48PM +0100, Frank Wunderlich wrote: > Just to make it clear...the issue with the copper-sfps is no regression of this series it exists before. > i only had none of them to test for until this weekend....my 1g fibre-sfp were working fine with the inband-flag. > > this patch tries to fix it in mtk driver, this was rejected (as far as i understand it should be handled in phylink core instead of pcs driver). > and no more in the v13, so we try to fix it another way. > > whatever i do in phylink_parse_mode the link is always inband...i tried to add a new state to have the configuration not FIXED or PHY or INBAND > > drivers/net/phy/phylink.c > @@ -151,6 +151,7 @@ static const char *phylink_an_mode_str(unsigned int mode) > [MLO_AN_PHY] = "phy", > [MLO_AN_FIXED] = "fixed", > [MLO_AN_INBAND] = "inband", > + [MLO_AN_INBAND_DISABLED] = "inband disabled", > }; > > include/linux/phylink.h > @@ -20,6 +20,7 @@ enum { > MLO_AN_PHY = 0, /* Conventional PHY */ > MLO_AN_FIXED, /* Fixed-link mode */ > MLO_AN_INBAND, /* In-band protocol */ > + MLO_AN_INBAND_DISABLED > > is my start the right way?
Oh ffs.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| ![\](/images/icornerr.gif) |