Messages in this thread | | | Date | Sun, 12 Mar 2023 14:47:38 +0100 | Subject | Re: [PATCH 1/2] pwm: rcar: drop of_match_ptr for ID table | From | Krzysztof Kozlowski <> |
| |
On 12/03/2023 14:46, Uwe Kleine-König wrote: > On Sat, Mar 11, 2023 at 06:37:34PM +0100, Krzysztof Kozlowski wrote: >> The driver can match only via the DT table so the table should be always >> used and the of_match_ptr does not have any sense (this also allows ACPI >> matching via PRP0001, even though it might not be relevant here). >> >> drivers/pwm/pwm-rcar.c:252:34: error: ‘rcar_pwm_of_table’ defined but not used [-Werror=unused-const-variable=] > > The commit log text sounds like a harmless optimisation, but the error > message here either means you're fixing a compile failure, or (and?) the > patch was sent out before the commit log was finalized. > > Looking at it this is the error message that triggers if you compile > this driver with OF unset. I'd like to have that mentioned, then the > patch looks fine. Ditto for the 2nd patch in this series.
Sure, ack!
Best regards, Krzysztof
| |