lkml.org 
[lkml]   [2023]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID table
Date


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Samstag, 11. März 2023 18:33
> To: Andrew Lunn <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>;
> Vladimir Oltean <olteanv@gmail.com>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Hauke
> Mehrtens <hauke@hauke-m.de>; Woojung Huh
> <woojung.huh@microchip.com>; UNGLinuxDriver@microchip.com; Claudiu
> Manoil <claudiu.manoil@nxp.com>; Alexandre Belloni
> <alexandre.belloni@bootlin.com>; Colin Foster <colin.foster@in-
> advantage.com>; Hennerich, Michael <Michael.Hennerich@analog.com>;
> Alexander Aring <alex.aring@gmail.com>; Stefan Schmidt
> <stefan@datenfreihafen.org>; Miquel Raynal <miquel.raynal@bootlin.com>;
> Heiner Kallweit <hkallweit1@gmail.com>; Russell King
> <linux@armlinux.org.uk>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-wpan@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID
> table
>
> The driver will match mostly by DT table (even thought there is regular ID
> table) so there is little benefit in of_match_ptr (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
>
> drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’
> defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
> drivers/net/ieee802154/adf7242.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/adf7242.c
> b/drivers/net/ieee802154/adf7242.c
> index 5cf218c674a5..509acc86001c 100644
> --- a/drivers/net/ieee802154/adf7242.c
> +++ b/drivers/net/ieee802154/adf7242.c
> @@ -1336,7 +1336,7 @@ MODULE_DEVICE_TABLE(spi, adf7242_device_id);
> static struct spi_driver adf7242_driver = {
> .id_table = adf7242_device_id,
> .driver = {
> - .of_match_table = of_match_ptr(adf7242_of_match),
> + .of_match_table = adf7242_of_match,
> .name = "adf7242",
> .owner = THIS_MODULE,
> },
> --
> 2.34.1

\
 
 \ /
  Last update: 2023-03-27 00:55    [W:0.173 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site