lkml.org 
[lkml]   [2023]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 3/5] sunrpc: simplify one-level sysctl registration for xs_tunables_table
    Date
    There is no need to declare an extra tables to just create directory,
    this can be easily be done with a prefix path with register_sysctl().

    Simplify this registration.

    Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
    ---
    net/sunrpc/xprtsock.c | 13 ++-----------
    1 file changed, 2 insertions(+), 11 deletions(-)

    diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
    index aaa5b2741b79..46bbd6230650 100644
    --- a/net/sunrpc/xprtsock.c
    +++ b/net/sunrpc/xprtsock.c
    @@ -77,7 +77,7 @@ static unsigned int xs_tcp_fin_timeout __read_mostly = XS_TCP_LINGER_TO;

    /*
    * We can register our own files under /proc/sys/sunrpc by
    - * calling register_sysctl_table() again. The files in that
    + * calling register_sysctl() again. The files in that
    * directory become the union of all files registered there.
    *
    * We simply need to make sure that we don't collide with
    @@ -157,15 +157,6 @@ static struct ctl_table xs_tunables_table[] = {
    { },
    };

    -static struct ctl_table sunrpc_table[] = {
    - {
    - .procname = "sunrpc",
    - .mode = 0555,
    - .child = xs_tunables_table
    - },
    - { },
    -};
    -
    /*
    * Wait duration for a reply from the RPC portmapper.
    */
    @@ -3174,7 +3165,7 @@ static struct xprt_class xs_bc_tcp_transport = {
    int init_socket_xprt(void)
    {
    if (!sunrpc_table_header)
    - sunrpc_table_header = register_sysctl_table(sunrpc_table);
    + sunrpc_table_header = register_sysctl("sunrpc", xs_tunables_table);

    xprt_register_transport(&xs_local_transport);
    xprt_register_transport(&xs_udp_transport);
    --
    2.39.1
    \
     
     \ /
      Last update: 2023-03-27 00:55    [W:3.908 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site