Messages in this thread | | | Subject | Re: [PATCH] pata_parport: fix possible memory leak | From | Sergey Shtylyov <> | Date | Sat, 11 Mar 2023 23:23:25 +0300 |
| |
On 3/11/23 11:19 PM, Sergei Shtylyov wrote:
>> When ida_alloc() fails, "pi" is not freed although the misleading >> comment says otherwise. >> Move the ida_alloc() call up so we really don't have to free it.
Wait, but don't we still need to call kfree() in pi_init_one()?
>> Reported-by: kernel test robot <lkp@intel.com> >> Reported-by: Dan Carpenter <error27@gmail.com> >> Link: https://lore.kernel.org/r/202303111822.IHNchbkp-lkp@intel.com/ >> Signed-off-by: Ondrej Zary <linux@zary.sk> > > Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > [...]
MBR, Sergey
| |