Messages in this thread | | | Date | Sat, 11 Mar 2023 19:12:29 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH] PCI: apple: Initialize pcie->nvecs before using it |
| |
On Sat, 11 Mar 2023 13:34:53 +0000, Sven Peter <sven@svenpeter.dev> wrote: > > apple_pcie_setup_port computes ilog2(pcie->nvecs) to setup the number of > MSIs available for each port. It is however called before apple_msi_init > which actually initializes pcie->nvecs. > Luckily, pcie->nvecs is part of kzalloc-ed structure and thus > initialized as zero. ilog2(0) happens to be 0xffffffff which then just > configures more MSIs in hardware than we actually have. This doesn't > break anything because we never hand out those vectors. > Let's swap the order of the two calls so that we use the correctly > initialized value. > > Fixes: 476c41ed4597 ("PCI: apple: Implement MSI support") > Signed-off-by: Sven Peter <sven@svenpeter.dev>
Huh, how embarrassing... :-/
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
-- Without deviation from the norm, progress is not possible.
| |