Messages in this thread | | | Date | Sat, 11 Mar 2023 17:26:00 +0200 | Subject | Re: [PATCH v7 6/9] interconnect: qcom: rpm: Handle interface clocks | From | Dmitry Baryshkov <> |
| |
On 11/03/2023 16:38, Bryan O'Donoghue wrote: > On 11/03/2023 14:35, Dmitry Baryshkov wrote: >>> Its probably worthwhile experimenting to see if the*ufs*_clk can/should >>> be added to the UFS device list of clocks. >> While we were doing this for some of the clocks (PCIe and USB, if I'm >> not mistaken), I think that generally this is not fully correct. In my >> opinion it should be in the interconnect driver, who turns >> corresponding clocks on and off. These clocks correspond to the SoC >> topology, rather than the end-device. >> > > True enough, they are interconnect clocks. > > The question is how to only turn them on when the device that depends on > them wants them.
I think we can turn them on an off from qcom_icc_set(). Each node can list required clocks.
-- With best wishes Dmitry
| |