Messages in this thread | | | Date | Sat, 11 Mar 2023 15:52:23 +0200 | Subject | Re: [PATCH v7 1/9] interconnect: qcom: rpm: make QoS INVALID default | From | Dmitry Baryshkov <> |
| |
On 08/03/2023 23:40, Konrad Dybcio wrote: > Currently NOC_QOS_MODE_FIXED is defined as 0x0 which makes it the > default option (partial struct initialization). The default option > however should be NOC_QOS_MODE_INVALID. > > That results in bogus QoS configurations being sent for port 0 (which > is used for the DRAM endpoint on BIMC, for example) coming from all nodes > with .qos.ap_owned = true and uninitialized .qos.qos_mode. It's also an > issue for newer SoCs where all nodes are treated as if they were ap_owned, > but not all of them have QoS configuration. > > The NOC_QOS_MODEs are defined as preprocessor constants and are not used > anywhere outside qcom_icc_set_noc_qos(), which is easily worked around. > Separate the desc->type values from the values sent to msmbus in the > aforementioned function. Make the former an enum for better mainainability. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |