Messages in this thread | | | From | "Edgecombe, Rick P" <> | Subject | Re: [PATCH v7 34/41] x86/shstk: Support WRSS for userspace | Date | Fri, 10 Mar 2023 17:16:16 +0000 |
| |
On Fri, 2023-03-10 at 17:44 +0100, Borislav Petkov wrote:
Thanks on text edits.
> > > > +/* Helper that can never get accidentally un-inlined. */ > > +#define set_clr_bits_msrl(msr, set, clear) do { \ > > Uff, pls kill this thing. > > Our MSR interfaces universe is already insane and arch/x86/lib/msr.c > already has similar attempts to what you're doing here in addition to > all the other gunk in msr.h. > > I highly doubt this can't be done the usual way, lemme see...
Seems reasonable.
| |