lkml.org 
[lkml]   [2023]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 0/2] Apple Magic Keyboard Backlight
Date

> Hi,
>
> thanks for creating the support for backlight.
>
> Is there any reason why not to fold all this into existing hid-apple? I
> don't think we need separate driver for the backlist, separated from the
> rest of hid-apple support.
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>

As far as I know, hid-apple manages the keyboards and trackpads on Macs.

The magic backlight is managed by the touchbar on T2 Macs, so if you wanna integrate the driver in some other one, then it should be the to-be-upstreamed touchbar driver.

But when we did that, the MacBook Air 2020, the model which has magic backlight, but no touchbar faced issues. lsusb interestingly shows presence of touch bar backlight even on this model, but backlight is registered at the 0th interface on Air, and 1st interface on the Pros. So, the co-author, Kerem Karabay suggested using a separate driver.

Although, the authors may give more detailed reason for the same.
\
 
 \ /
  Last update: 2023-03-27 00:53    [W:1.821 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site