Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 10 Mar 2023 10:16:10 -0600 | Subject | Re: [PATCH 1/2] staging: greybus: Fix Alignment with parenthesis | From | Alex Elder <> |
| |
On 3/10/23 9:51 AM, Menna Mahmoud wrote: > Fix " CHECK: Alignment should match open parenthesis " > Reported by checkpath > > Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
Is this (and your second patch) the only place(s) where this issue gets reported?
I think this type of alignment is not a major problem, and alignment isn't done this way in general in this driver, it's probably OK to keep it that way.
-Alex
> --- > drivers/staging/greybus/fw-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/fw-core.c b/drivers/staging/greybus/fw-core.c > index 57bebf24636b..f562cb12d5ad 100644 > --- a/drivers/staging/greybus/fw-core.c > +++ b/drivers/staging/greybus/fw-core.c > @@ -89,7 +89,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, > } > > connection = gb_connection_create(bundle, cport_id, > - gb_fw_mgmt_request_handler); > + gb_fw_mgmt_request_handler); > if (IS_ERR(connection)) { > ret = PTR_ERR(connection); > dev_err(&bundle->dev,
| ![\](/images/icornerr.gif) |