lkml.org 
[lkml]   [2023]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: hugetlb: move hugeltb sysctls to its own file
From


On 2023/3/9 20:20, Kefeng Wang wrote:
> This moves all hugetlb sysctls to its own file, also kill an
> useless hugetlb_treat_movable_handler() defination.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> include/linux/hugetlb.h | 8 -------
> kernel/sysctl.c | 32 --------------------------
> mm/hugetlb.c | 51 ++++++++++++++++++++++++++++++++++++++---
> 3 files changed, 48 insertions(+), 43 deletions(-)
>

> +#ifdef CONFIG_SYSCTL
> +static void hugetlb_sysctl_init(void);

Hi Luis,this should add __init as it is called by hugetlb_init,
could you help to change it, or I could send a new patch.


> +#else
> +static inline void hugetlb_sysctl_init(void) { }
> +#endif
> +
> static int __init hugetlb_init(void)
> {
> int i;
> @@ -4257,6 +4263,7 @@ static int __init hugetlb_init(void)
>
> hugetlb_sysfs_init();
> hugetlb_cgroup_file_init();
> + hugetlb_sysctl_init();
>
...
> +
> +static void hugetlb_sysctl_init(void)

ditto, sorry for the mistake.

Thanks.

> +{
> + register_sysctl_init("vm", hugetlb_table);
> +}
> #endif /* CONFIG_SYSCTL */
>
> void hugetlb_report_meminfo(struct seq_file *m)

\
 
 \ /
  Last update: 2023-03-27 00:53    [W:0.112 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site