Messages in this thread | | | Date | Fri, 10 Mar 2023 14:53:03 +0100 | Subject | Re: [PATCH] tracing/osnoise: set several trace_osnoise.c variables storage-class-specifier to static | From | Daniel Bristot de Oliveira <> |
| |
On 3/9/23 16:04, Tom Rix wrote: > smatch reports several similar warnings > kernel/trace/trace_osnoise.c:220:1: warning: > symbol '__pcpu_scope_per_cpu_osnoise_var' was not declared. Should it be static? > kernel/trace/trace_osnoise.c:243:1: warning: > symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static? > kernel/trace/trace_osnoise.c:335:14: warning: > symbol 'interface_lock' was not declared. Should it be static? > kernel/trace/trace_osnoise.c:2242:5: warning: > symbol 'timerlat_min_period' was not declared. Should it be static? > kernel/trace/trace_osnoise.c:2243:5: warning: > symbol 'timerlat_max_period' was not declared. Should it be static? > > These variables are only used in trace_osnoise.c, so it should be static > > Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
-- Daniel
| |