Messages in this thread | | | Date | Fri, 10 Mar 2023 12:28:50 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH] atm: he: fix potential ioremap leak of membase in he_dev |
| |
Gencen Gan <u202011061@gmail.com> : > In the function he_start() in drivers/atm/he.c, there > is no unmapping of he_dev->membase in the branch that > exits due to an error like reset failure, which may > cause a memory leak.
Why would he_dev->membase not be unmapped in he_stop() ?
he_stop() is paired with he_start() as soon a he_start() returns anything different from 0 in he_init_one(). I see no other place where he_start() is used.
The atm_dev/he_dev pointers also seem correctly set.
-- Ueimor
| |