lkml.org 
[lkml]   [2023]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] reiserfs: remove duplicate include header in xattr.c
On Tue, Mar 07, 2023 at 03:17:05PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> linux/xattr.h is included more than once.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---

I mean, yeah, it's included in the local xattr.h file but honestly
reiserfs is marked deprecated and I just don't think that we should
bother with cleaning up things that are _that_ minor. If it was the
compiler complaining about some unused variable then for sure but this
just seems pointless imho at this terminal stage...

> fs/reiserfs/xattr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
> index 651027967159..ed1984775a4f 100644
> --- a/fs/reiserfs/xattr.c
> +++ b/fs/reiserfs/xattr.c
> @@ -43,7 +43,6 @@
> #include <linux/fs.h>
> #include <linux/file.h>
> #include <linux/pagemap.h>
> -#include <linux/xattr.h>
> #include "xattr.h"
> #include "acl.h"
> #include <linux/uaccess.h>
> --
> 2.25.1

\
 
 \ /
  Last update: 2023-03-27 00:53    [W:0.049 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site