Messages in this thread | | | Subject | Re: [PATCH v1 1/2] dt-bindings: spi: add loongson spi | From | zhuyinbo <> | Date | Fri, 10 Mar 2023 17:33:18 +0800 |
| |
在 2023/3/10 下午5:08, Krzysztof Kozlowski 写道: > On 10/03/2023 03:31, zhuyinbo wrote: >> 在 2023/3/8 下午10:06, Rob Herring 写道: >>> On Wed, 08 Mar 2023 10:59:07 +0800, Yinbo Zhu wrote: >>>> Add the Loongson platform spi binding with DT schema format using >>>> json-schema. >>>> >>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >>>> --- >>>> .../bindings/spi/loongson,ls-spi.yaml | 47 +++++++++++++++++++ >>>> MAINTAINERS | 6 +++ >>>> 2 files changed, 53 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >>>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> Error: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dts:22.28-29 syntax error >>> FATAL ERROR: Unable to parse input tree >>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dtb] Error 1 >>> make[1]: *** Waiting for unfinished jobs.... >>> make: *** [Makefile:1512: dt_binding_check] Error 2 >>> >>> doc reference errors (make refcheckdocs): >> This yaml patch need depend on >> >> https://lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@loongson.cn/ >> >> , then yaml compile will be successfull. > Nothing in the patch changelog (where it is preferred), not even cover > letter, mention dependencies.
okay, I will add it in changelog in next version.
> > Best regards, > Krzysztof
| |