Messages in this thread | | | From | <> | Subject | Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe | Date | Fri, 10 Mar 2023 09:14:56 +0000 |
| |
On 09.03.2023 17:05, Cheng Ziqiu wrote: >>From the comment of platform_get_irq, it only returns non-zero IRQ > number and negative error number, other than zero. > > Fix this by removing the if condition. > > Signed-off-by: Cheng Ziqiu <chengziqiu@hust.edu.cn>
I see From and 1st SoB matches but
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
this SoB seems extra. What is the contribution of Dongliang Mu to this patch?
> --- > drivers/iio/adc/at91-sama5d2_adc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index 50d02e5fc6fc..168399092590 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev) > st->dma_st.phys_addr = res->start; > > st->irq = platform_get_irq(pdev, 0); > - if (st->irq <= 0) { > - if (!st->irq) > - st->irq = -ENXIO; > - > + if (st->irq < 0) > return st->irq; > - } > > st->per_clk = devm_clk_get(&pdev->dev, "adc_clk"); > if (IS_ERR(st->per_clk)) > -- > 2.34.1 >
| |