lkml.org 
[lkml]   [2023]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v3 13/21] KVM: selftests: Drop now-redundant checks on PERF_CAPABILITIES writes
    From
    Now that vcpu_set_msr() verifies the expected "read what was wrote"
    semantics of all durable MSRs, including PERF_CAPABILITIES, drop the
    now-redundant manual checks in the VMX PMU caps test.

    Signed-off-by: Sean Christopherson <seanjc@google.com>
    ---
    tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c b/tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c
    index 035470b38400..f7a27b5c949b 100644
    --- a/tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c
    +++ b/tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c
    @@ -51,10 +51,7 @@ static void test_basic_perf_capabilities(union perf_capabilities host_cap)
    struct kvm_vm *vm = vm_create_with_one_vcpu(&vcpu, NULL);

    vcpu_set_msr(vcpu, MSR_IA32_PERF_CAPABILITIES, 0);
    - ASSERT_EQ(vcpu_get_msr(vcpu, MSR_IA32_PERF_CAPABILITIES), 0);
    -
    vcpu_set_msr(vcpu, MSR_IA32_PERF_CAPABILITIES, host_cap.capabilities);
    - ASSERT_EQ(vcpu_get_msr(vcpu, MSR_IA32_PERF_CAPABILITIES), host_cap.capabilities);

    kvm_vm_free(vm);
    }
    @@ -67,9 +64,6 @@ static void test_fungible_perf_capabilities(union perf_capabilities host_cap)
    /* testcase 1, set capabilities when we have PDCM bit */
    vcpu_set_msr(vcpu, MSR_IA32_PERF_CAPABILITIES, PMU_CAP_FW_WRITES);

    - /* check capabilities can be retrieved with KVM_GET_MSR */
    - ASSERT_EQ(vcpu_get_msr(vcpu, MSR_IA32_PERF_CAPABILITIES), PMU_CAP_FW_WRITES);
    -
    /* check whatever we write with KVM_SET_MSR is _not_ modified */
    vcpu_run(vcpu);
    ASSERT_EQ(vcpu_get_msr(vcpu, MSR_IA32_PERF_CAPABILITIES), PMU_CAP_FW_WRITES);
    --
    2.40.0.rc1.284.g88254d51c5-goog
    \
     
     \ /
      Last update: 2023-03-27 00:54    [W:2.481 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site