lkml.org 
[lkml]   [2023]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] usb: typec: hd3ss3220: Drop of_match_ptr for ID table
From
On 3/10/23 14:29, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here).
>
> drivers/usb/typec/hd3ss3220.c:284:34: error: ‘dev_ids’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/usb/typec/hd3ss3220.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
> index 746ef3a75b76..8bbeb9b1e439 100644
> --- a/drivers/usb/typec/hd3ss3220.c
> +++ b/drivers/usb/typec/hd3ss3220.c
> @@ -290,7 +290,7 @@ MODULE_DEVICE_TABLE(of, dev_ids);
> static struct i2c_driver hd3ss3220_driver = {
> .driver = {
> .name = "hd3ss3220",
> - .of_match_table = of_match_ptr(dev_ids),
> + .of_match_table = dev_ids,
> },
> .probe_new = hd3ss3220_probe,
> .remove = hd3ss3220_remove,

\
 
 \ /
  Last update: 2023-03-27 00:54    [W:0.090 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site