Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 10 Mar 2023 23:50:57 +0100 | Subject | Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523 |
| |
On Fri, Mar 10, 2023 at 7:35 PM Jianhua Lu <lujianhua000@gmail.com> wrote: > On Fri, Mar 10, 2023 at 07:10:21PM +0100, Konrad Dybcio wrote: > > > > > +#define mipi_dsi_dual_dcs_write_seq(dsi0, dsi1, cmd, seq...) \ > > > + do { \ > > > + mipi_dsi_dcs_write_seq(dsi0, cmd, seq); \ > > > + mipi_dsi_dcs_write_seq(dsi1, cmd, seq); \ > > > + } while (0) > > This should be in the same file as mipi_dsi_dcs_write_seq, imo > I have sent a patch to do it, upstream don't think this wrapper is a proper > approach to deal with dual dsi and wrap all of mipi_dsi_* function is > useless. > https://lore.kernel.org/lkml/20230310110542.6649-1-lujianhua000@gmail.com/
We can keep it locally if the fight isn't worthwhile, but I will try to enter the discussion.
Yours, Linus Walleij
| |