lkml.org 
[lkml]   [2023]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] bnx2: remove deadcode in bnx2_init_cpus()
On Fri, 10 Mar 2023 10:33:46 +0300 Maxim Korotkov wrote:
> Path with error handling was deleted in 57579f7629a3 ("bnx2: Use
> request_firmware()"). This patch is needed to improving readability.
> Now checking the value of the return value is misleading when reading
> the code.
> Do I need to add this argument to the patch description?

Yes please.

> I also forgot to add mark Reviewed-by: Leon Romanovsky
> <leonro@nvidia.com> from the previous iteration

So this is not the first revision? Please add Leon's tag and an
appropriate vN. e.g. [PATCH net-next v2].

In general we don't encourage cleanup of this sort because the number
of int functions which always return 0 is rather large in the kernel,
but if you already got an ack from Leon we'll consider it, so please
adjust and repost.

\
 
 \ /
  Last update: 2023-03-27 00:52    [W:0.061 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site