Messages in this thread | | | Date | Tue, 7 Feb 2023 14:31:18 +0100 | Subject | Re: [PATCH v3 3/6] dt-bindings: bus: add STM32 System Bus | From | Gatien CHEVALLIER <> |
| |
Hello Jonathan,
On 1/28/23 16:48, Jonathan Cameron wrote: > On Fri, 27 Jan 2023 17:40:37 +0100 > Gatien Chevallier <gatien.chevallier@foss.st.com> wrote: > >> Document STM32 System Bus. This bus is intended to control firewall >> access for the peripherals connected to it. >> >> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> >> Signed-off-by: Loic PALLARDY <loic.pallardy@st.com> > Trivial comment on formatting. > >> + >> +examples: >> + - | >> + // In this example, the rng1 device refers to etzpc as its domain controller. >> + // Same goes for fmc. >> + // Access rights are verified before creating devices. >> + >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/clock/stm32mp1-clks.h> >> + #include <dt-bindings/reset/stm32mp1-resets.h> >> + >> + etzpc: bus@5c007000 { >> + compatible = "st,stm32mp15-sys-bus"; >> + reg = <0x5c007000 0x400>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + feature-domain-controller; >> + #feature-domain-cells = <1>; >> + >> + rng1: rng@54003000 { > > Odd mixture of 4 spacing and 2 spacing in this example. > I'd suggest one or the other (slight preference for 4 space indents). >
Thank you for spotting this, I'll change to 4 space indents
> >> + compatible = "st,stm32-rng"; >> + reg = <0x54003000 0x400>; >> + clocks = <&rcc RNG1_K>; >> + resets = <&rcc RNG1_R>; >> + feature-domains = <&etzpc 7>; >> + status = "disabled"; >> + };
Best regards, Gatien
| |