Messages in this thread | | | Subject | Re: [PATCH 03/10] media: Add Y212 video format | From | Nicolas Dufresne <> | Date | Wed, 22 Feb 2023 10:31:14 -0500 |
| |
Hi Hans, Ming,
Le vendredi 27 janvier 2023 à 15:37 +0100, Hans Verkuil a écrit : > On 20/12/2022 04:11, Ming Qian wrote: > > Y212 is a YUV format with 12-bits per component like YUYV, > > expanded to 16bits. > > Data in the 12 high bits, zeros in the 4 low bits, > > arranged in little endian order. > > > >
[...]
> > @@ -618,6 +618,7 @@ struct v4l2_pix_format { > > #define V4L2_PIX_FMT_YUVA32 v4l2_fourcc('Y', 'U', 'V', 'A') /* 32 YUVA-8-8-8-8 */ > > #define V4L2_PIX_FMT_YUVX32 v4l2_fourcc('Y', 'U', 'V', 'X') /* 32 YUVX-8-8-8-8 */ > > #define V4L2_PIX_FMT_M420 v4l2_fourcc('M', '4', '2', '0') /* 12 YUV 4:2:0 2 lines y, 1 line uv interleaved */ > > +#define V4L2_PIX_FMT_Y212 v4l2_fourcc('Y', '2', '1', '2') /* 32 YUYV 12-bit per component */ > > This definitely needs to be renamed to prevent repeating the 'P010' mistake. > > It's a YUYV format, so perhaps: _YUYV_12? > > You definitely need to have 'YUYV' in the name in order to deal with different > YUV orders.
Hans, it seems you already accepted this exact same format from Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> / [PATCH v3 2/7] media: Add Y210, Y212 and Y216 formats.
Tomi omitted to update v4l2-common.c file. Ming, do you mind keeping this part of your patch (adding Y210/Y216 support), this way we'd get that properly implemented.
Nicolas
p.s. We can alternatively change our mind as this is not final yet I think.
[...]
| |