Messages in this thread | | | Date | Thu, 14 Dec 2023 16:25:11 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next] net: dsa: dont use generic selftest strings for custom selftests |
| |
On Thu, Dec 14, 2023 at 03:21:36PM +0100, Ante Knezic wrote: > if dsa device supports custom selftests than we should use custom > selftest strings for ethtool. > > Signed-off-by: Ante Knezic <ante.knezic@helmholz.de> > ---
I didn't notice when the selftest support was added that there is no implementation in DSA drivers of custom ds->ops->self_test(). Adding interfaces with no users is frowned upon, precisely because it doesn't show the big picture.
You must have noticed this because you do have a driver implementation, so would you mind posting it together with this fix?
| |