Messages in this thread | | | Date | Thu, 14 Dec 2023 15:58:56 +0300 | Subject | Re: [PATCH v3 04/11] leds: aw2013: use devm API to cleanup module's resources | From | George Stark <> |
| |
Hello Nikita
Thanks for the review and testing.
On 12/14/23 08:42, Nikita Travkin wrote: > George Stark писал(а) 14.12.2023 03:30: >> In this driver LEDs are registered using devm_led_classdev_register() >> so they are automatically unregistered after module's remove() is done. >> led_classdev_unregister() calls module's led_set_brightness() to turn off >> the LEDs and that callback uses resources which were destroyed already >> in module's remove() so use devm API instead of remove(). >> >> Signed-off-by: George Stark <gnstark@salutedevices.com> > > Thanks for noticing and fixing this! > Perhaps this patch needs a Fixes tag too, like 1/11?
This patch and the rest of the series depend on new feature devm_mutex_init and if I add Fixes tag this feature will need to be backported too along with fixes. I'm not sure it's desirable.
> > Tested-by: Nikita Travkin <nikita@trvn.ru> > > Btw, seems like (5..11)/11 never arrived to the lists...
Yeah there was a delay, but now all patches from series #3 are online. > > Nikita > >> --- ...
-- Best regards George
| |