Messages in this thread | | | From | JustinLai0215 <> | Subject | RE: [PATCH net-next v14 01/13] rtase: Add pci table supported in this module | Date | Thu, 14 Dec 2023 12:42:57 +0000 |
| |
> -----Original Message----- > From: Paolo Abeni <pabeni@redhat.com> > Sent: Tuesday, December 12, 2023 5:36 PM > To: JustinLai0215 <justinlai0215@realtek.com>; kuba@kernel.org > Cc: davem@davemloft.net; edumazet@google.com; > linux-kernel@vger.kernel.org; netdev@vger.kernel.org; andrew@lunn.ch; > Ping-Ke Shih <pkshih@realtek.com>; Larry Chiu <larry.chiu@realtek.com> > Subject: Re: [PATCH net-next v14 01/13] rtase: Add pci table supported in this > module > > > External mail. > > > > On Fri, 2023-12-08 at 17:47 +0800, Justin Lai wrote: > [...] > > +static void rtase_remove_one(struct pci_dev *pdev) { > > + struct net_device *dev = pci_get_drvdata(pdev); > > + struct rtase_private *tp = netdev_priv(dev); > > + struct rtase_int_vector *ivec; > > + u32 i; > > + > > + for (i = 0; i < tp->int_nums; i++) { > > + ivec = &tp->int_vector[i]; > > + netif_napi_del(&ivec->napi); > > + } > > You must unregister the netdev before napi_del or you will risk races.
Ok, Thank you for your suggestion.
> > Cheers, > > Paolo
| |