Messages in this thread | | | Date | Thu, 14 Dec 2023 11:11:06 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v3 1/4] ASoC: qcom: common: Add qcom_snd_tdm_hw_params function |
| |
On Wed, Dec 13, 2023 at 08:35:53PM +0800, Jianhua Lu wrote:
> Add qcom TDM setup function to support TDM ports for qcom platform.
> +int qcom_snd_tdm_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params) > +{
...
> + ret = snd_soc_dai_set_tdm_slot(cpu_dai, tx_mask, rx_mask, slots, slot_width); > + if (ret < 0) {
The expectation is that TDM is set up by the machine driver, not from hw_params - if the TDM setup can be changed from within hw_params then it's hard to see how it's going to interact well with other TDM users on the bus. More usually hw_params() would be influenced by the setup done in set_tdm_slot(). [unhandled content-type:application/pgp-signature] | |