Messages in this thread | | | Date | Thu, 14 Dec 2023 15:52:57 +0530 | Subject | Re: [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes | From | Om Prakash Singh <> |
| |
On 12/14/2023 12:52 PM, Krzysztof Kozlowski wrote: > On 14/12/2023 06:41, Om Prakash Singh wrote: >> >> >> On 12/12/2023 8:32 PM, Krzysztof Kozlowski wrote: >>> On 12/12/2023 14:32, Om Prakash Singh wrote: >>>> Add the QCE and Crypto BAM DMA nodes. >>>> >>>> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com> >>>> --- >>>> >>>> Changes in V2: >>>> - Update DT node sequence as per register ascending order >>> >>> Hm, I don't see it... >>> >>>> - Fix DT node properties as per convention >>>> >>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >>>> index 66f1eb83cca7..7b705df21f4e 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >>>> @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 { >>>> status = "disabled"; >>>> }; >>>> >>>> + cryptobam: dma-controller@1dc4000 { >>> >>> It still looks like not correctly ordered by unit address against other >>> nodes in the file. >>> >> >> Hi Krzysztof, >> Probably I am missing something basic here. I am trying to put entries >> addresses that are sorted wrt their current adjacent. >> >> And it looks fine to me. >> >> 1c0e000 (current exist) >> 1dc4000 (newly added) >> 1dfa000 (newly added) >> 1e40000 (current exist) > > Then why the diff shows: > @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 { > above your changes?
my mistake! Local change was not added in updated patch. Submitting V3
> > Best regards, > Krzysztof >
| |