Messages in this thread | | | Date | Thu, 14 Dec 2023 09:48:02 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v5 18/44] drm/vc4: hdmi: Create destroy state implementation |
| |
Hi Dave,
On Tue, Dec 12, 2023 at 11:40:26AM +0000, Dave Stevenson wrote: > On Thu, 7 Dec 2023 at 15:50, Maxime Ripard <mripard@kernel.org> wrote: > > > > Even though we were rolling our own custom state for the vc4 HDMI > > controller driver, we were still using the generic helper to destroy > > that state. > > > > It was mostly working since the underlying state is the first member of > > our state so the pointers are probably equal in all relevant cases, but > > it's still fragile so let's fix this properly. > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Thanks for the review, I've applied that patch now.
Could you also review the framework changes (patches 6 to 16) ?
Thanks! Maxime [unhandled content-type:application/pgp-signature] | |