Messages in this thread | | | Date | Thu, 14 Dec 2023 13:37:44 -0800 | From | Kees Cook <> | Subject | Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time |
| |
On Thu, Dec 14, 2023 at 09:06:12PM +0000, tanzirh@google.com wrote: > This patch includes linux/kernel.h in asm/word-at-a-time.h for the > sh architecture. WORD_AT_A_TIME_CONSTANTS depends on kernel.h. > Making this implicit dependancy explicit allows for later improvements > in the lib/string.c inclusion list. > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
This patch is missing your Signed-off-by: tag.
Also, please double-check your email configs: your full name is missing from your emails (it's just "tanzirh@google.com"): https://lore.kernel.org/lkml/20231214-libstringheader-v2-1-0f195dcff204@google.com/
But otherwise, the change itself looks fine. :)
-- Kees Cook
| |