Messages in this thread | | | Date | Thu, 14 Dec 2023 21:10:46 +0000 | From | Al Viro <> | Subject | Re: [PATCH v1] clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h |
| |
On Thu, Dec 14, 2023 at 10:59:57AM +0000, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > As evidenced by the fact that only 2 other drivers include this header, > it is not a normal thing to do. Including the regular version of this > header is far more conventional for drivers.
ACK. Includes of asm-generic/anything.h are fine in arch/*/include/* and (under some circumstances) in include/*; anywhere else they are very dubious, including outright bugs (io_uring/uring_cmd.h include of asm-generic/ioctls.h, for example).
| |