lkml.org 
[lkml]   [2023]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] media: dt-bindings: samsung,s5p-mfc: Fix iommu properties schemas
On Thu, Dec 14, 2023 at 1:42 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 13/12/2023 23:42, Rob Herring wrote:
> > The iommus and iommu-names property schemas have several issues. First,
> > 'iommus-names' in the if/then schemas is the wrong name. As all the names
> > are the same, they can be defined at the top level instead. Then the
> > if/then schemas just need to define how many entries. The iommus if/then
> > schemas are also redundant. Best I can tell, the desire was to require 2
> > entries for "samsung,exynos5433-mfc", "samsung,mfc-v5", "samsung,mfc-v6",
> > and "samsung,mfc-v8".
> >
>
> ...
>
> > - iommus-names: false
> > + iommu-names: false
> >
> > - if:
> > properties:
> > @@ -102,11 +104,9 @@ allOf:
> > - const: aclk
> > - const: aclk_xiu
> > iommus:
> > - maxItems: 2
> > - iommus-names:
> > - items:
> > - - const: left
> > - - const: right
> > + minItems: 2
> > + iommu-names:
> > + minItems: 2
> >
> > - if:
> > properties:
> > @@ -123,11 +123,9 @@ allOf:
> > - const: mfc
> > - const: sclk_mfc
> > iommus:
> > - maxItems: 2
> > + minItems: 2
> > iommus-names:
>
> Also here -> iommu-names

Sigh. I got distracted with everything else that needed fixing.

Rob

\
 
 \ /
  Last update: 2023-12-14 20:53    [W:0.156 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site