Messages in this thread | | | Date | Thu, 14 Dec 2023 19:45:24 +0000 | From | Simon Horman <> | Subject | Re: [net-next PATCH v2] octeontx2-af: Fix multicast/mirror group lock/unlock issue |
| |
On Wed, Dec 13, 2023 at 03:23:49PM +0530, Suman Ghosh wrote: > As per the existing implementation, there exists a race between finding > a multicast/mirror group entry and deleting that entry. The group lock > was taken and released independently by rvu_nix_mcast_find_grp_elem() > function. Which is incorrect and group lock should be taken during the > entire operation of group updation/deletion. This patch fixes the same. > > Fixes: 51b2804c19cd ("octeontx2-af: Add new mbox to support multicast/mirror offload") > Signed-off-by: Suman Ghosh <sumang@marvell.com> > --- > Note: This is a follow up of > > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_netdev_net-2Dnext_c_51b2804c19cd&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=7si3Xn9Ly-Se1a655kvEPIYU0nQ9HPeN280sEUv5ROU&m=NjKPoTkYVlL5Dh4aSr3-dVo-AukiIperlvB0S4_Mqzkyl_VcYAAKrWhkGZE5Cx-p&s=AkBf0454Xm-0adqV0Os7ZE8peaCXtYyuNbCS5kit6Jk&e= > > v2 changes: > - Addresed review comments from Simon about a missed unlock and re-org the code > with some goto labels.
Thanks Suman,
this one looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
| |