Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Mon, 9 Oct 2023 08:51:22 +0200 | Subject | Re: [PATCH] gpio: vf610: update comment for i.MX8ULP and i.MX93 legacy compatibles |
| |
On Sat, Oct 7, 2023 at 2:51 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > > From: Peng Fan <peng.fan@nxp.com> > > i.MX8ULP and i.MX93 legacy compatible strings use dual regs, while > new compatible strings use one reg. The "support old compatible strings" > is not clear to reflect the fact, so update it. > > Suggested-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > > To address: > https://lore.kernel.org/all/20231004050428.o7l2e23xjcjkzzck@pengutronix.de/ > Marco: > I added your tag with Suggested-by, since you suggested this. > > drivers/gpio/gpio-vf610.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c > index c03dfda41d4c..a89ae84a1fa0 100644 > --- a/drivers/gpio/gpio-vf610.c > +++ b/drivers/gpio/gpio-vf610.c > @@ -287,7 +287,10 @@ static int vf610_gpio_probe(struct platform_device *pdev) > > dual_base = port->sdata->have_dual_base; > > - /* support old compatible strings */ > + /* > + * Handle legacy compatible combinations which used two reg values > + * for the i.MX8ULP and i.MX93. > + */ > if (device_is_compatible(dev, "fsl,imx7ulp-gpio") && > (device_is_compatible(dev, "fsl,imx93-gpio") || > (device_is_compatible(dev, "fsl,imx8ulp-gpio")))) > -- > 2.37.1 >
Applied, thanks!
Bart
| |