lkml.org 
[lkml]   [2023]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] fs/sysfs/group: make attribute_group pointers const
On Mon, Oct 09, 2023 at 07:25:57PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 09, 2023 at 06:57:39PM +0200, Max Kellermann wrote:
> > This allows passing arrays of const pointers. The goal is to make
> > lots of global variables "const" to allow them to live in the
> > ".rodata" section.
>
> I'm all for doing this type of work, but this is going to be rough. You
> sent patch 6/7 that hit almost all subsystems at once :(

The way to do this right is one-subsystem-at-a-time, right? Why not
start there, doing it cleanly, and then at the end, change the driver
core and then just the subsystem pointers? That should be much simpler,
easier to review and verify, and many more changes (and probably take a
kernel release or two to get through.)

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-10-09 19:32    [W:0.174 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site