Messages in this thread | | | From | "Joey Jiao (QUIC)" <> | Subject | RE: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode | Date | Mon, 9 Oct 2023 01:14:31 +0000 |
| |
Right, it will be only useful for low memory kernel where 'KASAN_SANITIZE :=y' has to be added explicitly in local as hotfix.
-----Original Message----- From: Masahiro Yamada <masahiroy@kernel.org> Sent: Saturday, September 30, 2023 6:12 PM To: Alexander Potapenko <glider@google.com> Cc: Joey Jiao (QUIC) <quic_jiangenj@quicinc.com>; kasan-dev@googlegroups.com; Kevin Ding (QUIC) <quic_likaid@quicinc.com>; Andrey Ryabinin <ryabinin.a.a@gmail.com>; Andrey Konovalov <andreyknvl@gmail.com>; Dmitry Vyukov <dvyukov@google.com>; Vincenzo Frascino <vincenzo.frascino@arm.com>; Nathan Chancellor <nathan@kernel.org>; Nick Desaulniers <ndesaulniers@google.com>; Nicolas Schier <nicolas@fjasle.eu>; linux-kernel@vger.kernel.org; linux-kbuild@vger.kernel.org Subject: Re: [PATCH] kasan: Add CONFIG_KASAN_WHITELIST_ONLY mode
On Fri, Sep 29, 2023 at 11:06 PM Alexander Potapenko <glider@google.com> wrote: > > (CC Masahiro Yamada) > > On Thu, Sep 28, 2023 at 6:16 AM Joey Jiao <quic_jiangenj@quicinc.com> wrote: > > > > Fow low memory device, full enabled kasan just not work. > > Set KASAN_SANITIZE to n when CONFIG_KASAN_WHITELIST_ONLY=y. > > So we can enable kasan for single file or module. > > I don't have technical objections here, but it bothers me a bit that > we are adding support for KASAN_SANITIZE:=y, although nobody will be > adding KASAN_SANITIZE:=y to upstream Makefiles - only development > kernels when debugging on low-end devices. > > Masahiro, is this something worth having in upstream Kconfig code?
Even if we apply this patch to the upstream, you will end up with adding 'KASAN_SANITIZE :=y' to the single file/Makefile.
I am not convinced with this patch since this nod is not so useful standalone.
> > Signed-off-by: Joey Jiao <quic_jiangenj@quicinc.com> > Reviewed-by: Alexander Potapenko <glider@google.com>
-- Best Regards Masahiro Yamada
| |