lkml.org 
[lkml]   [2023]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drm/msm/dpu: Use the encoder for default CRC source
From


On 08/10/2023 16:59, Dmitry Baryshkov wrote:
> On Sun, 8 Oct 2023 at 20:56, Rob Clark <robdclark@gmail.com> wrote:
>>
>> From: Rob Clark <robdclark@chromium.org>
>>
>> i-g-t expects the CRC to reflect any applied CTM. But the layer mixer
>> source is upstream of the DSPP, so it is before the CTM is applied.
>>
>> Switch the default source to 'encoder' instead so that the CRC is
>> captured downstream of the DSPP.
>>
>> Signed-off-by: Rob Clark <robdclark@chromium.org>
>> ---
>> drivers/gpu/drm/ci/xfails/msm-sc7180-fails.txt | 4 ----
>> drivers/gpu/drm/ci/xfails/msm-sc7180-skips.txt | 5 -----
>> drivers/gpu/drm/ci/xfails/msm-sdm845-fails.txt | 11 +----------
>> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 +++---
>
> I'm not sure, if updating the CI skip list together with the
> functional changs is a good idea, my preference would be towards two
> separate patches.

On the other hand, having both together in the same patch documents
which tests this PATCH is fixing.

Regards,
Helen

>
> Nevertheless:
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
>> 4 files changed, 4 insertions(+), 22 deletions(-)
>
>

\
 
 \ /
  Last update: 2023-10-09 01:21    [W:0.851 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site