Messages in this thread | | | From | Mateusz Guzik <> | Date | Sun, 8 Oct 2023 22:26:40 +0200 | Subject | Re: [PATCH v2 5/5] fs: Add inode_assert_locked() and inode_assert_locked_excl() |
| |
On 10/7/23, Matthew Wilcox (Oracle) <willy@infradead.org> wrote: > +static inline void inode_assert_locked_excl(const struct inode *inode) > +{ > + rwsem_assert_held_write(&inode->i_rwsem); > +} > + > static inline void inode_lock_nested(struct inode *inode, unsigned > subclass) > { > down_write_nested(&inode->i_rwsem, subclass);
Why "excl" instead of "write"? Apart from looking weird, it is inconsistent with "prior art" in the file: i_mmap_assert_write_locked.
-- Mateusz Guzik <mjguzik gmail.com>
| |