Messages in this thread | | | Date | Sun, 8 Oct 2023 13:21:07 +0200 | Subject | Re: [PATCH v2] dt-bindings: mtd: cadence: convert cadence-nand-controller.txt to yaml | From | Krzysztof Kozlowski <> |
| |
On 05/10/2023 07:15, niravkumar.l.rabara@intel.com wrote: > From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com> > > Convert cadence-nand-controller.txt to yaml format. > Update cadence-nand-controller.txt to cadence,nand.yaml in MAINTAINER file. >
> +allOf: > + - $ref: nand-controller.yaml > + > +properties: > + compatible: > + items: > + - const: cdns,hp-nfc > + > + reg: > + items: > + - description: Address and length of the controller register set
Just "Controller register set"
> + - description: Address and length of the Slave DMA data port
"Slave DMA data port" or "Slave DMA data port register set"
> + > + reg-names: > + items: > + - const: reg > + - const: sdma > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + dmas: > + maxItems: 1 > + > + cdns,board-delay-ps: > + description: | > + Estimated Board delay. The value includes the total round trip > + delay for the signals and is used for deciding on values associated > + with data read capture. The example formula for SDR mode is the > + following. > + board delay = RE#PAD delay + PCB trace to device + PCB trace from device > + + DQ PAD delay > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + nand-controller@10b80000 {
This does not look properly indented. Should start at | before. IOW: Use 4 spaces for example indentation.
> + compatible = "cdns,hp-nfc"; > + reg = <0x10b80000 0x10000>, > + <0x10840000 0x10000>;
Please align it properly with opening <
> + reg-names = "reg", "sdma"; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = <0 97 4>;
Use defines for interrupt flags.
> + clocks = <&nf_clk>; > + cdns,board-delay-ps = <4830>; > + > + nand@0 { > + reg = <0>; > + }; > + };
Best regards, Krzysztof
| |