Messages in this thread | | | Date | Sat, 7 Oct 2023 12:04:25 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH v5 00/10] Add Milk-V Pioneer RISC-V board support |
| |
On Sat, Oct 07, 2023 at 06:58:51PM +0800, Chen Wang wrote: > > On 2023/10/7 18:17, Conor Dooley wrote: > > On Sat, Oct 07, 2023 at 03:52:04PM +0800, Chen Wang wrote: > > > From: Chen Wang <unicorn_wang@outlook.com> > > > > > > Milk-V Pioneer [1] is a developer motherboard based on SOPHON SG2042 [2] > > > in a standard mATX form factor. Add minimal device > > > tree files for the SG2042 SOC and the Milk-V Pioneer board. > > > > > > Now only support basic uart drivers to boot up into a basic console. > > > > > > Thanks, > > > Chen > > > > > > --- > > > > > > Changes in v5: > > > The patch series is based on v6.6-rc1. You can simply review or test > > > the patches at the link [7]. > > > - dts: changed plic to support external interrupt > > > - pickup improvements from Conor, details refer to [8]. > > Did you? I only see them partially picked up. I'll just replace patch 8 > > with the patch 8 from this series I think. > > Yes, only the patch 8 of this series(v5) is updated for plic node. For other > patches, I just cherry-picked them from previous "sophon" branch.
But added my signoff? I ended up seeing my signoff on the patch where I disagreed with the commit message, which was confusing to me.
> BTW, what I did this time may be a bit redundant. I would like to ask, if I > encounter a similar situation in the future (that is, only one patch needs > to be modified, and the others remain unchanged), is there a better way to > submit the patchset?
You could have sent the plic change as a incremental change on top. So a new patch with just that one change in it.
Thanks, Conor. [unhandled content-type:application/pgp-signature] | |