lkml.org 
[lkml]   [2023]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 08/10] scsi: scsi_debug: Add new error injection reset lun failed
From
On 2023/10/7 5:04, Douglas Gilbert wrote:
> On 2023-09-22 05:29, Wenchao Hao wrote:
>> Add error injection type 3 to make scsi_debug_device_reset() return FAILED.
>> Fail abort command foramt:
>
> s/foramt/format/
>
>>
>> Examples:
>>      error=/sys/kernel/debug/scsi_debug/0:0:0:1/error
>>      echo "0 -10 0x12" > ${error}
>
> These examples are misleading. Same with the one in patch 7/10 . The example
> should be showing an invocation that exercises _this_ patch. So the first
> byte of the echo should be 4 not the 0 shown above.
>
> Doug Gilbert
>

Would update in next version. Would you continue reviewing patch 9/10 and 10/10?

\
 
 \ /
  Last update: 2023-10-07 11:46    [W:0.085 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site