Messages in this thread | | | Date | Sat, 7 Oct 2023 17:45:32 +0800 | Subject | Re: [PATCH v5 08/10] scsi: scsi_debug: Add new error injection reset lun failed | From | Wenchao Hao <> |
| |
On 2023/10/7 5:04, Douglas Gilbert wrote: > On 2023-09-22 05:29, Wenchao Hao wrote: >> Add error injection type 3 to make scsi_debug_device_reset() return FAILED. >> Fail abort command foramt: > > s/foramt/format/ > >> >> Examples: >> error=/sys/kernel/debug/scsi_debug/0:0:0:1/error >> echo "0 -10 0x12" > ${error} > > These examples are misleading. Same with the one in patch 7/10 . The example > should be showing an invocation that exercises _this_ patch. So the first > byte of the echo should be 4 not the 0 shown above. > > Doug Gilbert >
Would update in next version. Would you continue reviewing patch 9/10 and 10/10?
| |