lkml.org 
[lkml]   [2023]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7 02/26] PM / devfreq: rockchip-dfi: Embed desc into private data struct
    From
    On 23. 7. 4. 18:32, Sascha Hauer wrote:
    > No need for an extra allocation, just embed the struct
    > devfreq_event_desc into the private data struct.
    >
    > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
    > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
    > ---
    > drivers/devfreq/event/rockchip-dfi.c | 8 ++------
    > 1 file changed, 2 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
    > index 74893c06aa087..467f9f42d38f7 100644
    > --- a/drivers/devfreq/event/rockchip-dfi.c
    > +++ b/drivers/devfreq/event/rockchip-dfi.c
    > @@ -49,7 +49,7 @@ struct dmc_usage {
    > */
    > struct rockchip_dfi {
    > struct devfreq_event_dev *edev;
    > - struct devfreq_event_desc *desc;
    > + struct devfreq_event_desc desc;
    > struct dmc_usage ch_usage[RK3399_DMC_NUM_CH];
    > struct device *dev;
    > void __iomem *regs;
    > @@ -204,14 +204,10 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
    >
    > data->dev = dev;
    >
    > - desc = devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL);
    > - if (!desc)
    > - return -ENOMEM;
    > -
    > + desc = &data->desc;
    > desc->ops = &rockchip_dfi_ops;
    > desc->driver_data = data;
    > desc->name = np->name;
    > - data->desc = desc;
    >
    > data->edev = devm_devfreq_event_add_edev(&pdev->dev, desc);
    > if (IS_ERR(data->edev)) {

    Applied it. Thanks.

    --
    Best Regards,
    Samsung Electronics
    Chanwoo Choi

    \
     
     \ /
      Last update: 2023-10-06 18:08    [W:4.149 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site