lkml.org 
[lkml]   [2023]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7 01/26] PM / devfreq: rockchip-dfi: Make pmu regmap mandatory
    From
    On 23. 7. 4. 18:32, Sascha Hauer wrote:
    > As a matter of fact the regmap_pmu already is mandatory because
    > it is used unconditionally in the driver. Bail out gracefully in
    > probe() rather than crashing later.
    >
    > Fixes: b9d1262bca0af ("PM / devfreq: event: support rockchip dfi controller")
    > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
    > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
    > ---
    >
    > Notes:
    > Changes since v4:
    > - move to beginning of the series to make it easier to backport to stable
    > - Add a Fixes: tag
    > - add missing of_node_put()
    >
    > drivers/devfreq/event/rockchip-dfi.c | 15 ++++++++-------
    > 1 file changed, 8 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
    > index 39ac069cabc75..74893c06aa087 100644
    > --- a/drivers/devfreq/event/rockchip-dfi.c
    > +++ b/drivers/devfreq/event/rockchip-dfi.c
    > @@ -193,14 +193,15 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
    > return dev_err_probe(dev, PTR_ERR(data->clk),
    > "Cannot get the clk pclk_ddr_mon\n");
    >
    > - /* try to find the optional reference to the pmu syscon */
    > node = of_parse_phandle(np, "rockchip,pmu", 0);
    > - if (node) {
    > - data->regmap_pmu = syscon_node_to_regmap(node);
    > - of_node_put(node);
    > - if (IS_ERR(data->regmap_pmu))
    > - return PTR_ERR(data->regmap_pmu);
    > - }
    > + if (!node)
    > + return dev_err_probe(&pdev->dev, -ENODEV, "Can't find pmu_grf registers\n");
    > +
    > + data->regmap_pmu = syscon_node_to_regmap(node);
    > + of_node_put(node);
    > + if (IS_ERR(data->regmap_pmu))
    > + return PTR_ERR(data->regmap_pmu);
    > +
    > data->dev = dev;
    >
    > desc = devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL);

    Applied it. Thanks.

    --
    Best Regards,
    Samsung Electronics
    Chanwoo Choi

    \
     
     \ /
      Last update: 2023-10-06 18:03    [W:5.643 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site