Messages in this thread | | | Date | Fri, 6 Oct 2023 17:47:05 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH v12 0/3] Add multiport support for DWC3 controllers |
| |
On Thu, Oct 05, 2023 at 02:32:54PM +0530, Krishna Kurapati PSSNV wrote: > On 10/5/2023 12:06 PM, Johan Hovold wrote: > > On Wed, Oct 04, 2023 at 10:29:19PM +0530, Krishna Kurapati wrote:
> >> Krishna Kurapati (3): > >> usb: dwc3: core: Access XHCI address space temporarily to read port > >> info > >> usb: dwc3: core: Skip setting event buffers for host only controllers > >> usb: dwc3: qcom: Add helper function to request threaded IRQ > > > > NAK. > > > > These patches make very little sense on their own and can't really be > > evaluated without the context of the larger series. > > > > Just work on getting the multiport series in shape and include any acks > > you've received so far when submitting new revisions.
> This may be partially true for first patch of this series, (where we > read num_ports), but the other two patches are self explanatory and are > applicable for non-mp controllers as well. Intention was to ensure we > make the next rebase easy.
No, just send the whole series at once.
> Will try to address all comments and send v12 again as a whole series > this week. I am actually blocked on [1]. Not able to repro the compile > error on my end. That's what stopped me from sending all at once.
Looks like your buffer is too small for a u8 index. Should be easy to fix.
Johan
> [1]: https://lore.kernel.org/all/202309200156.CxQ3yaLY-lkp@intel.com/
| |